Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix translation emails #1101

Closed
wants to merge 1 commit into from
Closed

Fix translation emails #1101

wants to merge 1 commit into from

Conversation

almet
Copy link
Member

@almet almet commented Dec 10, 2022 •
edited
Loading

Another take at #1016

@almet almet changed the title Almet/fix translation emails Fix translation emails Dec 10, 2022
@almet almet mentioned this pull request Dec 10, 2022
Closed
@almet almet force-pushed the almet/fix-translation-emails branch from 6b8aa11 to f3ddc73 Compare December 10, 2022 17:01
@almet
Use Jinja2 {% trans %} blocks for email templates.
c36a936 
Inspired by code from @a-angeles13, thanks to him!

Add .format() fixes needed for pybabel.

See python-babel/babel#715
@almet almet force-pushed the almet/fix-translation-emails branch from f3ddc73 to c36a936 Compare December 11, 2022 12:10
@almet
Copy link
Member Author

almet commented Dec 19, 2024

Closing this for now, let's reopen if we think it's worth it.

@almet almet closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@almet